Open
Conversation
PaLoMaster
reviewed
May 27, 2019
|
|
||
| while (DOMdocument == null) { | ||
| try { | ||
| Thread.sleep(1000); |
Collaborator
There was a problem hiding this comment.
Меня пока только вот этот блок смущает... Не приведёт ли к зависанию...?
Collaborator
|
@Vladim1r37, нашёл два бага по твоей доработке:
|
PaLoMaster
reviewed
May 30, 2019
| String avatar = initAvatar(false); //man | ||
| String styleStr = "background-image: url(" + avatar + "); background-size: cover"; | ||
| // | ||
| idMsg++; |
Collaborator
There was a problem hiding this comment.
Думаю, что вот эти айди нужно менять на айди сообщения mess.getId().
Collaborator
|
Первый пункт (ссылки) заработал, а со вторым (вертикальный скрол кареткой) у меня что-то не очень результат: когда каретку прокрутки упираешь вверх, то практически мгновенно загружается весь чат до первого сообщения... Хотя, если честно, не представляю - можно ли это улучшить? Возможно, это потому, что что-то не обновляется в интерфейсе по javaFX? Или наоборот - обновляется и каретка перемещается вверх? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.